Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General reorganization and fix #22. #34

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

StoneyJackson
Copy link
Collaborator

  • Move all JSON files to configs/.
  • Simplify client code.
  • Move all library code into grade module (grade.py)
  • Move all tests into tests package.
  • Add run_tests.py to run all the tests.
  • Fix Allow multiple verbosity levels #22 .

Ultimately the JSON files should probably be stored along with their courses and
be removed from this repository. That way, if there is a change to a course,
this repository should not change.

* Move all JSON files to configs/.
* Move all Python files except assignmentconvert.py under grade/.
* grade/ is now the root python package for this project.
* Add run_tests.py to run all the tests.

Ultimately the JSON files should probably be stored along with their courses and
be removed from this repository. That way, if there is a change to a course,
this repository should not change.
In Python, modules are used to group related classes (and functions, attributes,
constants, etc.). When importing a module, one wants to import everything
related to that topic. In our case, Assignment and Command work together to
form the assignment processing engine.
@StoneyJackson StoneyJackson changed the title General reorganization. General reorganization and fix #22. Jul 13, 2014
I think

    from submissions import Processor
    ...
    class ToPdf(Processor):

reads better than

    from grade import App
    ...
    class ToPdf(App):
    Command('ls "{ins}"')

should now be

    Command('ls {ins}')
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow multiple verbosity levels
1 participant